Integrating Touch Compatibility with cycle

[keeganbrown]

Hi malsup,

I've taken some initial strides with integrating touch compatibility into your jQuery Cycle plug-in. There's a lot of work to be done to update individual transitions to be touch friendly. For now, I've made versions of scrollHorz and scrollVert.

Please let me know what you think!

Thanks.

keeganbrown

[gradynoonen]

dragStart, dragMove, and dragEnd are not global in scope and, therefore, unrecognized here.

[keeganbrown]

d'oh! pushed a quick fix up for now, might rework when I find time. Thanks for the feedback!

[gradynoonen]

Awesome! Great work on this, by the way. I've been playing with it and am
really impressed. FYI, I declared those three variables outside all
functions, and that's also been working great. Have you done much testing
with multitouch capable devices? It does not play nicely with more than one
finger touch events.

On Tue, Jun 19, 2012 at 12:43 PM, Keegan Brown <
reply@reply.github.com

wrote:

•         mouseover: touchPause,
  

•         mouseout: touchUnpause
  

• });
  

• //TOUCHMOD -- PREVENT TRANSITIONS IF USER IS HOVERING OVER CYCLE +
  

  opts.touchClickDrag == true

• $cont.bind({
  

•         mouseover: touchPause,
  

•         mouseout: touchUnpause
  

• });
  

  +}
  +function destroyTouch (cont, opts) {

• var $cont = $(cont);
  

• $cont.unbind('touchstart touchmove touchend touchcancel');
  

• if (opts.touchClickDrag) {
  

•         $cont.unbind({
  

•                 mousedown: dragStart,
  

d'oh! pushed a quick fix up for now, might rework when I find time.

---

Reply to this email directly or view it on GitHub:
https://github.com/malsup/cycle/pull/110/files#r1011630

[keeganbrown]

Glad you like it! It's a little rough around the edges (as you can tell), and if I found time, I might clean things up a bit. Didn't really put any effort in to multitouch. Right now it only cares about the first finger you touch the screen with. Are you seeing other errors related to multitouch rather than just support or lack thereof?

[gradynoonen]

I don't see any need for multitouch support. What you've got working is really clean and smooth - exactly the functionality I'd expect from this. What I'm seeing is errors surrounding multitouch. I noticed it bugging out a little bit occasionally, and eventually realized that it was when I was accidentally touching with two fingers, or if I put a second finger down while I was still interacting with the first. I might play around with that piece if I have time. I'll let you know if I come up with a solution.

[riverofjanuary]

Sorry, how do I download this? I want to play around with it too please!

[keeganbrown]

My fork with touch compatibility lives here: https://github.com/keeganbrown/cycle. Work in progress (as if anything is ever finished...) so use in production at your own risk.