Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move node-fetch types to dev dependencies #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move node-fetch types to dev dependencies #489

wants to merge 1 commit into from

Conversation

rowanu
Copy link

@rowanu rowanu commented Feb 6, 2024

Currently @types/node-fetch is included in dependencies which is bloating production builds with types:

notion-sdk-js/package.json

Line 43 in b66c67d

"@types/node-fetch": "^2.5.10",

Types aren't used in production, so this makes no functional difference, this PR just moves it in to devDependencies like the other @types/... dependencies.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohammedEsafi MohammedEsafi MohammedEsafi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rowanu @CLAassistant @MohammedEsafi