Vanguard integration #2254
Merged
Vanguard integration #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 11, 2019 15:48
magda-gateway/package.json
Outdated
| @@ -43,6 +43,7 @@ | |||
| "passport-facebook": "^2.0.0", | |||
| "passport-google-oauth20": "^1.0.0", | |||
| "passport-local": "^1.0.0", | |||
| "passport-wsfed-saml2": "^3.0.17", | |||
There was a problem hiding this comment.
I think we might need to fork our version of this with the x509 and cryptiles problems patched out :(. No need for you to get to this before you go though.
There was a problem hiding this comment.
There was a problem hiding this comment.
Will native x509 dependency cause problems? It just needs build tools for npm install.
There was a problem hiding this comment.
Apparently it breaks on node > 8?
There was a problem hiding this comment.
There's already a PR to get rid of it, but it's been sitting since October :(
AlexGilleran
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #2008
This PR contains functionality necessary for connecting magda instances to vanguard through ws-fed protocol.
How to test.
For whoever picking this up, remaining stuff including private keys etc is here: https://drive.google.com/drive/folders/1vniUnRqOIfvyUy8nekDueITwEUUKzs96
Checklist