Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying an endpoint_url override #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

doy-stripe
Copy link
Contributor

KMS doesn't have in-VPC endpoints yet, so we need to be able to proxy our KMS requests through a known host in order to meaningfully restrict egress from our machines. This pull request allows overriding the KMS endpoint used by the AWS bindings. This relies on lyft/python-kmsauth#11 and so will also require a dependency bump once that is released.

@ryan-lane
Copy link
Contributor

Looks good. Need to update the tests, though :). Have you tested sending None into the endpoint url arg in the boto3 lib?

@ryan-lane
Copy link
Contributor

New change looks good too, excluding lint failure. Has this been tested, same question as before though, have you tested with sending None to the function in boto3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants