Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45725: Change default table engine to MyISAM #99

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

Change the default MySQL table engine to MyISAM in the data model, for two main reasons:

  • This is the table engine used by Qserv, so we want to match it as closely as possible.
  • Some of the tables are exceeding the maximum number of columns allowed by the InnoDB engine.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (a4a3dd8) to head (266d708).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   90.80%   90.74%   -0.06%     
==========================================
  Files          16       16              
  Lines        1805     1805              
  Branches      386      386              
==========================================
- Hits         1639     1638       -1     
  Misses        101      101              
- Partials       65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-45725 branch 3 times, most recently from 7c958a0 to ec45a82 Compare August 12, 2024 22:52
Copy link

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matching Qserv is reasonable

The default MySQL engine was changed to MyISAM, due to its support for
wider tables and usage in qserv, so update the doc to reflect this.
@JeremyMcCormick JeremyMcCormick merged commit d24166b into main Aug 16, 2024
14 of 15 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-45725 branch August 16, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants