Skip to content

Commit

Permalink
Remove some now unncessary handling of arraysize from tap module
Browse files Browse the repository at this point in the history
Several of these checks have been put into the data model instead and
should not be necessary to repeat here.
  • Loading branch information
JeremyMcCormick committed Oct 3, 2024
1 parent d4f7218 commit 2e978e7
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions python/felis/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,7 @@ def visit_column(self, column_obj: datamodel.Column, table_obj: Table) -> Tap11B
felis_type = FelisType.felis_type(felis_datatype.value)
column.datatype = column_obj.votable_datatype or felis_type.votable_name

column.arraysize = column_obj.votable_arraysize or (
column_obj.length if (column_obj.length is not None and column_obj.length > 1) else None
)
if (felis_type.is_timestamp or column_obj.datatype == "text") and column.arraysize is None:
column.arraysize = "*"
column.arraysize = column_obj.votable_arraysize

def _is_int(s: str) -> bool:
try:
Expand Down

0 comments on commit 2e978e7

Please sign in to comment.