[cert] move cert keygen function to otbn_boot_services lib #24440
+79
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the `cert_ecc_p256_keygen()` function from the `cert` lib to the `otbn_boot_services` lib to simplify on-host unit testing of the `cert` lib. The `otbn_boot_services` lib is only tested on-device at the moment due to the dependencies on specific OpenTitan hardware that is difficult to mock. In refactoring this, the cert_unittest is now fixed. Signed-off-by: Tim Trippel <ttrippel@google.com>
cfrantz
approved these changes
Aug 29, 2024
timothytrippel
added
the
CherryPick:earlgrey_1.0.0
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-24440-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-24440-to-earlgrey_1.0.0
git switch --create backport-24440-to-earlgrey_1.0.0
git cherry-pick -x bd3b9fd572b5b1a50f911f0623c054e4d6556d0f |
github-actions
bot
added
the
Manually CherryPick
timothytrippel
removed
Manually CherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
cert_ecc_p256_keygen()function from thecertlib to theotbn_boot_serviceslib to simplify on-host unit testing of thecertlib. Theotbn_boot_serviceslib is only tested on-device at the moment due to the dependencies on specific OpenTitan hardware that is difficult to mock. In refactoring this, the cert_unittest is now fixed.