[ottf,opentitanlib,test] Impl spi device ottf tx console #24380
Merged
+133
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonychen1251
force-pushed
the
impl-spi-device-ottf-tx-console
branch
2 times, most recently
from
1f6fed2
to
f459c6a
Compare
|
The failed test case |
This updates the console module to support TX direction by issuing upload commands. The write address of the last data chunk will be set to a special address, informing Device that the transmission is completed and Device can stop its busy wait state for further upload commands. Signed-off-by: Anthony Chen <antchen@google.com>
This adds support for reading data via the OTTF SPI device console. Device keeps waiting spi upload commands and then transfers data in chunks until a transmission complete signal (special address) is received. Signed-off-by: Anthony Chen <antchen@google.com>
This tests the OTTF spi_device console in TX direction. Signed-off-by: Anthony Chen <antchen@google.com>
anthonychen1251
force-pushed
the
impl-spi-device-ottf-tx-console
branch
from
f459c6a
to
1adb01a
Compare
|
Just realized that it's unnecessary to send an extra upload command to inform the Device that the transmission is complete. Update the commits and the comment with the termination approach. |
timothytrippel
requested review from
timothytrippel and
pamaury
and removed request for
a team
timothytrippel
approved these changes
Aug 26, 2024
timothytrippel
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three commits that:
Workflow:
Transmission Completion:
This PR addresses #21726 partially. The support for ujson_ottf will be added in another PR.