-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a kasm blurb that can be used on all KasmVNC based images #290
Conversation
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably also be on the docs page, by having the same blurb in the docs template.
I am a bot, here are the test results for this PR:
|
It still targets only the readme, but should also be mentioned in the documentation. |
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
This can be setup to add information after the app setup block using the following variables:
If only the
kasm_blurb: true
is set all defaults will be set as laid out here minus the nvidia support that needs to be specifically enabled for images that support it as Alpine does not. The Alpine blurb in the Nvidia section is to cover us for webtop or other images that may be multi distro base in the future.The ports are needed for images that are off the default 3000 and 3001, the maintainer will need to know what font noto package to use for their image base flavor here are the current packages:
Arch: noto-fonts-cjk
Debian/Ubuntu: fonts-noto-cjk
Alpine: font-noto-cjk
Fedora: google-noto-cjk-fonts
IE for webtop the inline readme-vars.yml will look like this: