Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librdmacm: Use overloadable function attribute with clang #1475

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Jun 22, 2024

This is to fix build warnings seen with upcoming clang19 and
glibc 2.40, since glibc 2.40 has improved fortyfying this
function with clang, it ends up with build errors like below

librdmacm/preload.c:796:9: error: at most one overload for a given name may lack the 'overloadable' attribute
| 796 | ssize_t recvfrom(int socket, void *buf, size_t len, int flags,
| | ^
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/rdma-core/51.0/recipe-sysroot/usr/include/sys/socket.h:163:16: note: previous unmarked overload of function is here
| 163 | extern ssize_t recvfrom (int __fd, void *__restrict __buf, size_t __n,
| | ^

@kraj
Copy link
Contributor Author

kraj commented Jun 23, 2024

It fails with musl as well, I will have to look into fixing it differently.

@kraj kraj marked this pull request as draft June 23, 2024 17:29
 This is to fix build warnings seen with upcoming clang19 and
 glibc 2.40, since glibc 2.40 has improved fortyfying this
 function with clang, it ends up with build errors like below

librdmacm/preload.c:796:9: error: at most one overload for a given name may lack the 'overloadable' attribute
|   796 | ssize_t recvfrom(int socket, void *buf, size_t len, int flags,
|       |         ^
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/rdma-core/51.0/recipe-sysroot/usr/include/sys/socket.h:163:16: note: previous unmarked overload of function is here
|   163 | extern ssize_t recvfrom (int __fd, void *__restrict __buf, size_t __n,
|       |                ^

Upstream-Status: Submitted [linux-rdma#1475]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant