add funding address param to FundNode query #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matthappens and the rest of your teammates on |
jklein24
reviewed
Aug 15, 2024
| suspend fun fundNode( | ||
| nodeId: String, | ||
| amountSats: Long?, | ||
| fundingAddress: String? |
There was a problem hiding this comment.
We should probably default this to null here and elsewhere.
jklein24
reviewed
Aug 15, 2024
| @@ -729,16 +729,22 @@ class LightsparkCoroutinesClient private constructor( | |||
| * | |||
| * @param nodeId The ID of the node to fund. Must be a REGTEST node. | |||
| * @param amountSats The amount of funds to add to the node. Defaults to 10,000,000 SATOSHI. | |||
| * @param fundingAddress: L1 address owned by funded node | |||
There was a problem hiding this comment.
Also maybe good to say what null means in this context (that it automatically creates a new funding address).
jklein24
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add funding address to FundNode query
add optional string
funding address