Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agentctl report command #1935

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

pemoticak
Copy link
Collaborator

@pemoticak pemoticak commented Jul 26, 2023

  • agentctl report command failed reporting transaction history because of unregistered models

  • VPP CLI commands for api tracing changed so adapt trace to these changes

  • output trace in JSON format which is more suited to automatic processing

  • use GenericClient to fetch agent NB config (allows for showing user defined models)

Signed-off-by: Peter Motičák peter.moticak@pantheon.tech

`agentctl report` failed reporting transaction history because of
unregistered models.

Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
@pemoticak pemoticak changed the title Fix agentctl report command WIP: Fix agentctl report command Jul 26, 2023
@pemoticak pemoticak marked this pull request as draft July 26, 2023 12:29
VPP CLI commands changed so adapt trace to these changes. Also output
trace in JSON format which is more suited to automatic processing.
Use GenericClient to fetch agent NB config.

Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
@pemoticak pemoticak changed the title WIP: Fix agentctl report command Fix agentctl report command Jul 31, 2023
@pemoticak pemoticak marked this pull request as ready for review July 31, 2023 12:28
@ondrej-fabry ondrej-fabry merged commit 1edf23d into ligato:master Aug 2, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants