Fix variable name collision #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. It's always important that global variables get named uniquely from whatever is defined in RetroArch for statically built targets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extern bool joypad_statein FUSE'ssrc/externs.hcollides with RetroArch's own use ofjoypad_state. On certain platforms, this causes this core to either fail to build entirely or crash when anything joypad-related occurs (usually, immediately upon game start).I've just renamed the FUSE variable from
joypad_statetojoyp_state, in line with the existingkeyb_statewhich tracks the keyboard.Fixes #138
Fixes #124
Might also fix the following: #133
Issue #121 was likely fixed by PR #139, but since the core stopped working on Wii U, this was not obvious until now. Regardless, that issue can also be closed.