-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MathML processing code and tests so that it works with file2brl #87
Conversation
This now works (again) with file2brl.
The MathCAT tests come from the Nemeth "green book". That book has lots of examples which are divided up into "rules", where each rule might have several parts and each part might have several examples. The tests are numbered so that one can easily refer back to the green book. For example, "overbar_86_b_10" is a test involving overbars. That test is Rule 86, part b, example 10. There is an extremely high failure rate (~85%) as documented in liblouis#88. I think some of these might be easy to fix but others I believe require significant changes to the archetecture or significant hacks/hooks to deal with.
Hi @NSoiffer, There is something I don't quite get. The Github Actions system tells us that the test suite worked fine, but your commit 451c74c made it fail. So I don't see how this is an improvement. Are you saying that on your system the test suite didn't work before and now it works? Your last commit which adds the many new tests is of course great. I'm thinking about how we can move these tests to Liblouis (like we did for UEB in liblouis/liblouis#1310), so that we can move nemeth.ctb back to Liblouis also (liblouis/liblouis#815). The problem is that I can not simply use the approach of liblouis/liblouis#1310 because nemeth.ctb is designed for use with nemeth.sem, not mathml.xsl. I have two options:
|
Hi, In tests/mathml_nemeth/liblouisutdml.ini I need do following modification to works the test system: Attila |
@NSoiffer, I forgot a thing:
Bert, possible happen checking error because not good the tests/mathml_nemeth/liblouis.ini the table path variables, and mismatch .github/workflow/sanitizer.yml file the Liblouis version? When I working @NorbertMarkus the #96 related pull request in monday, we experienced similar check results with first time. Hope this help, Attila |
Fixes liblouis#87 Signed-off-by: Attila Hammer <hammera@pickup.hu>
Has been superseded by #98 |
No description provided.