CI: Run CI workflow on pull requests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's run the CI workflow on pull requests, so that feedback is more immediate (well, to the degree that is possible). The only concern here could be that we now potentially run twice when creating a pull request and then merging it. But that seems like a tiny price to pay. If we were to force pull request creation we could remove running on push, but I am not sure that's worth it. Signed-off-by: Daniel Müller <deso@posteo.net>
|
|
|
¯\_(ツ)_/¯ let's give it a shot and see what happens. I'm a complete novice at Github actions. Support was generously implemented by someone else in c58bd53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's run the CI workflow on pull requests, so that feedback is more immediate (well, to the degree that is possible). The only concern here could be that we now potentially run twice when creating a pull request and then merging it. But that seems like a tiny price to pay. If we were to force pull request creation we could remove running on push, but I am not sure that's worth it.