Merge pull request #1528 from evoskuil/master

Make arena::detach() a NOEXCEPT method

include/bitcoin/system/arena.hpp

@@ -59,7 +59,7 @@ class arena
     /// Non-linear allocator just returns zero.
     /// Linear allocator returns current allocation size.
     /// Detachable linear allocator detaches allocation and returns its size.
-    virtual size_t detach() THROWS = 0;
+    virtual size_t detach() NOEXCEPT = 0;
 
     /// Non-linear and linear allocator is a nop.
     /// Detachable linear allocator frees the memory associated with memory.
@@ -94,7 +94,7 @@ class BC_API default_arena final
 public:
     static arena* get() NOEXCEPT;
     void* start(size_t baseline) THROWS override;
-    size_t detach() THROWS override;
+    size_t detach() NOEXCEPT override;
     void release(void* address) NOEXCEPT override;
 
 private:

src/arena.cpp

@@ -62,7 +62,7 @@ void* default_arena::start(size_t) THROWS
     return nullptr;
 }
 
-size_t default_arena::detach() THROWS
+size_t default_arena::detach() NOEXCEPT
 {
     return zero;
 }

test/test.hpp

@@ -132,7 +132,7 @@ class reporting_arena
         return nullptr;
     }
 
-    size_t detach() THROWS override
+    size_t detach() NOEXCEPT override
     {
         return zero;
     }
@@ -203,7 +203,7 @@ class mock_arena
         return nullptr;
     }
 
-    size_t detach() THROWS override
+    size_t detach() NOEXCEPT override
     {
         return zero;
     }