Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenMPT support #1551

Merged
merged 1 commit into from
May 17, 2024
Merged

Add OpenMPT support #1551

merged 1 commit into from
May 17, 2024

Conversation

SiegeLord
Copy link
Member

No description provided.

@SiegeLord SiegeLord mentioned this pull request Apr 11, 2024
Closed
@pedro-w
Copy link
Contributor

pedro-w commented Apr 11, 2024 •
edited
Loading

How do you disable DUMB in Cmake? All the other codecs seem to have a WANT_XXX variable, but not DUMB.

[edit] got it, it's WANT_MODAUDIO

@pedro-w
Copy link
Contributor

pedro-w commented Apr 12, 2024

How are you testing this? I tried using ex_acodec with some .mod files I have (and know to be ok) but the error dialog said "Could not load sample from 'XXX.mod'!" (nor did it work with the DUMB renderer on released version of A5 so I guess it's ex_acodec ?)

@SiegeLord
Copy link
Member Author

I compile it with both enabled, but hack it to use openmpt to load .xm files rather than DUMB. I generally use ex_stream_file with --loop or not. ex_stream_seek is also pretty good.

At the moment, I'm struggling to get looping to work, I don't really understand how openmpt handles looping (the only relevant APIs are openmpt_module_get_ctls with play.at_end and openmpt_module_set_repeat_count).

@SiegeLord SiegeLord force-pushed the openmpt branch 2 times, most recently from bcf1b3b to b465b5f Compare April 27, 2024 09:16
@SiegeLordEx @SiegeLord
Add OpenMPT support.
8c1f4f9 
OpenMPT is more maintained than DUMB. However, its output is different
from DUMBs, being slightly differently timed and also noticeably
quieter. For the latter, there is a hack to boost the volume by sqrt(2),
but we know some modules would in fact need to be boosted by 2.

Something to investigate further.
@SiegeLord SiegeLord marked this pull request as ready for review May 17, 2024 07:40
@SiegeLord SiegeLord merged commit 5435464 into liballeg:master May 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiegeLord @pedro-w @SiegeLordEx