Skip to content

Commit

Permalink
fix(IDX): dont send notification for skipped jobs (dfinity#1638)
Browse files Browse the repository at this point in the history
The existing filter doesn't seem to correctly prevent notifications for
skipped jobs, we'll ignore them if the conclusion was `skipped`.
  • Loading branch information
cgundy authored and levifeldman committed Oct 1, 2024
1 parent b00a43e commit b12c614
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/slack-workflow-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:

- name: Post Slack Notification
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
if: ${{ steps.setup.outputs.message != 'nothing' }}
if: ${{ github.event.workflow_run.conclusion != 'cancelled' }}
with:
channel-id: ${{ steps.setup.outputs.channel }}
slack-message: "${{ steps.setup.outputs.message }}"
Expand Down

0 comments on commit b12c614

Please sign in to comment.