Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T 13514/lens share link creator landing #25

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

hanahem
Copy link
Collaborator

@hanahem hanahem commented Aug 3, 2023

No description provided.

@height
Copy link

height bot commented Aug 3, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-13514" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lens-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 11:15am

Copy link
Member

@cesarenaldi cesarenaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanahem thank you! Great UX and solid work here!!

Compared to the ticket spec we are not supporting just Publication Id and Profile Id. I think it's ok.... I think most people would use anyway with an app link.

I left few comments that needs addressing.

Instead the "nit" comments are up to you. Not strong about it.

) : null}
</div>
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give some guidance in case we cannot build the link?

Something on these lines... maybe rework the copy with design?

We are sorry we couldn't build a Lens Share Link at this time.

You can however build it manually adopting one of these patterns:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Added this when the link couldn't be built.

const customPublicationUrl = SHARE_PUBLICATION_URL + publicationMatch[1];
return { type: "publication", url: customPublicationUrl };
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take the opportunity we know the App to add the attribution param: ?by=<app-id>. WDYT?

return (
<main>
<LinkGenerator />
</main>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would consider moving content of the LinkGeneratorcomponent into here until we know it needs to be a separate component. The level of indirection seems not needed here at the this moment in time.

)
}

export default Spinner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: favour named exports over default exports. Makes it for easier refactoring/renaming.

size?: string
}

const Spinner: FC<Props> = ({ color, size }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since this conversation I am personally not using FC<T> generic anymore. Seem it adds little/no-value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants