-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose publication types for usePublications query #414
Conversation
🦋 Changeset detectedLatest commit: 49f460d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request has been linked to 1 task:
|
value={value} | ||
onChange={(e) => { | ||
if (e.target.checked) { | ||
setPublicationTypes([...publicationTypes, value]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be a good use case for js Set
given we can't have duplicates in the array (or at least we don't want :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean sth like below? I don't think it's a case here as the value can only be set from a select box, and it can't be checked twice
setPublicationTypes(Array.from(new Set([...publicationTypes, value])));
2cad17d
to
49f460d
Compare
No description provided.