Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad blocker note #5628

Open
wants to merge 2 commits into
base: 0.17.x
Choose a base branch
from

Conversation

benjaoming
Copy link
Contributor

Summary

Fixes #5619

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

If you PR has a significant size, give the reviewer some helpful remarks

Issues addressed

List the issues solved or partly solved by the PR

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #5628 into 0.17.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5628   +/-   ##
=======================================
  Coverage   46.34%   46.34%           
=======================================
  Files         113      113           
  Lines        6514     6514           
=======================================
  Hits         3019     3019           
  Misses       3495     3495           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85c24b...986c31e. Read the comment docs.

@benjaoming
Copy link
Contributor Author

CC: @jamalex @aronasorman

This is ready to go in and be part of the next release. As clarified in a Notion project page, KA Lite will work fine if the Central Server is taken down. These string updates were IMO the closest I could come to a meaningful change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant