Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden download robustness #5545

Merged
merged 21 commits into from
Nov 27, 2017
Merged

Harden download robustness #5545

merged 21 commits into from
Nov 27, 2017

Commits on Nov 20, 2017

  1. Harden download robustness: Raise exceptions when non-200 download re… 

    …sponses, add tests for various failures, improve logging
    Benjamin Bach committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    4493da4 View commit details
    Browse the repository at this point in the history

  2. Release note for learningequality#5538 [ci skip]

    Benjamin Bach committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    d4d5eb4 View commit details
    Browse the repository at this point in the history

  3. Test youtube-dl fallback in videodownload command

    Benjamin Bach committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    c420639 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Add intelligent retrying + improve logging

    Benjamin Bach committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    01ce02e View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. In case of persistent socket or connection errors, retry with youtube… 

    …-dl instead
    Benjamin Bach committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    4f1da38 View commit details
    Browse the repository at this point in the history

  2. Simplify exception handling, better to catch this exception in outer … 

    …block where user is informed through UI
    Benjamin Bach committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    b191dc5 View commit details
    Browse the repository at this point in the history

  3. Add some real testing that we fallback to youtube-dl

    Benjamin Bach committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    c4b63e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2017

  1. Add download feedback for retrievecontentpack + Only keep retrying fo… 

    …r about 1 minute before giving up in download_file
    Benjamin Bach committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    680b679 View commit details
    Browse the repository at this point in the history

  2. slightly improve download speed by setting chunks to 50 KB

    Benjamin Bach committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    4ae6e3c View commit details
    Browse the repository at this point in the history

  3. Improve logging on content pack retrieval and add UI progress for con… 

    …tent pack downloads
    Benjamin Bach committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    2f22586 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2017

  1. Intermediate before giving up on youtube-dl

    Benjamin Bach committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    dacff98 View commit details
    Browse the repository at this point in the history

  2. Simplify download procedures by removing youtube-dl fallback (almost … 

    …entirely unused) learningequality#5547
    Benjamin Bach committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    272924c View commit details
    Browse the repository at this point in the history

  3. Fix broken progress bar layout in Manage>Languages

    Benjamin Bach committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    83c2899 View commit details
    Browse the repository at this point in the history

  4. Further tests of download exception handling

    Benjamin Bach committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    990c541 View commit details
    Browse the repository at this point in the history

  5. Reduce amount of retries, opt for deliberate pauses with user feedback

    Benjamin Bach committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    925f935 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Do not fail if video succeeds and thumbnail doesnt

    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    fa315ec View commit details
    Browse the repository at this point in the history

  2. Add tests for downloading and deleting content packs + delete content… 

    … db when deleting a content pack
    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    ed2f92c View commit details
    Browse the repository at this point in the history

  3. Ensure not to leave empty files behind when download fails

    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    b27d114 View commit details
    Browse the repository at this point in the history

  4. Fix progress tracking not updating from DB before checking `cancel_re… 

    …quested`
    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    89281be View commit details
    Browse the repository at this point in the history

  5. Raise DownloadCancelled when download has been cancelled and stop the… 

    … outer loop
    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    c916492 View commit details
    Browse the repository at this point in the history

  6. Add some more release notes clarifying download improvements

    Benjamin Bach committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    e941add View commit details
    Browse the repository at this point in the history