Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link component #6015

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

NishantSinghhhhh
Copy link

Description

Component Name : Link component present in Sistent component folder ,

This PR addresses various enhancements and features, including:

Documentation : I have written Documentation for the Link Component Used in Sistent Repository
Link Variants: Added different styles for links, including underlined and colored versions to enhance navigation and visibility.

Security Practices: Documented best practices for using links with target="_blank", highlighting the importance of rel="noopener" and rel="noreferrer" attributes to improve security.

Notes for Reviewers

Please pay special attention to the documentation and security notes for external links. Feedback on these changes would be greatly appreciated.

Signed commits**

Yes, I signed my commits.

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@github-actions github-actions bot added the area/projects An issue relating to Layer5 initiatives (projects) label Oct 21, 2024
@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit dfa3836 at: https://6715fb00a753f1fc9c4fac02--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit 3465ed8 at: https://6716033edc3fa002dc000554--layer5.netlify.app

@vishalvivekm
Copy link
Member

@NishantSinghhhhh I added the item to the docs:
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?tab=t.0

@NishantSinghhhhh
Copy link
Author

@vishalvivekm thank you so much Sir

Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit b0d80fd at: https://67167a8c43c3d76be6961631--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit e994890 at: https://671681a0c892347e07f863a7--layer5.netlify.app

Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit 1dbe06a at: https://67168a6c907aac827f285595--layer5.netlify.app

@NishantSinghhhhh
Copy link
Author

NishantSinghhhhh commented Oct 21, 2024

I have implemented the necessary changes as requested in the meet #6015 Please review the updates, and if everything meets the project requirements, I would appreciate your help in merging the PR

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


{7E727F6D-B416-4DD6-A672-4A3F45D89E41}


{1528FE11-9AFF-4F06-A020-315E56699D67}

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NishantSinghhhhh you can remove the topic download links , it doesn't make any sense because they same as basic links.

@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit e11cdb4 at: https://67173635c015755baff8bf8c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit 63d5022 at: https://671748c932848974d5d28df5--layer5.netlify.app

Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit 34692ae at: https://67175cbd20e23e8a978c8e97--layer5.netlify.app

Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Oct 22, 2024

🚀 Preview for commit 5685b94 at: https://671762903e850f867cc74570--layer5.netlify.app

Signed-off-by: NISHANT SINGH <151461374+NishantSinghhhhh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

4 participants