Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sources tab to lavalink API documentation. #1079

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mplatypus
Copy link
Contributor

Add sources tab to lavalinks API documentation pages.

Added sources. All but youtube links are missing.
Comment on lines +18 to +22
```yml title="application.yml"
server:
sources:
youtube: true
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work for the new yt plugin you mentioned above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do know that, didn't change it/haven't yet. Can do tommorrow :D

Comment on lines +28 to +29
- `ytsearch`: This will search `youtube.com` for relevant tracks/playlists.
- `ytmsearch`: This will search `music.youtube.com` for relevant tracks/playlists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the isrc syntax here? ytsearch:"%ISRC%"
also search results don't give back playlists
you should also add the : at the end I think
perhaps also that you put a search term behind the :
this needs to be added to all searches here


Searching using Bandcamp.

- `bcsearch`: This will search `bandcamp.com` for relevant tracks/playlists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also no playlists & search term + :


Searching using SoundCloud.

- `scsearch`: This will search `soundcloud.com` for relevant tracks/playlists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also no playlists & search term + :

Comment on lines +127 to +141
## Nico

Enabling this option:

```yml title="application.yml"
server:
sources:
nico: true
```

### URLs {: #nico-url }

Supported URL types

- FIXME: add url's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the current nico implementation doesn't work anymore, so you can ignore it until fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants