-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: issue forms with reason-listings #3476
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits.
value: | | ||
* SQLx version: [REQUIRED] | ||
* SQLx features enabled: [REQUIRED] | ||
* Database server and version: [REQUIRED] (MySQL / Postgres / SQLite <x.y.z>) | ||
* Operating system: [REQUIRED] | ||
* `rustc --version`: [REQUIRED] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well break these out into separate fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
This has the downside of looking a bit longer in the issue that is genereated, but that is likely an ok downside
attributes: | ||
label: Additional Context | ||
description: Add any other context or screenshots about the feature request here | ||
placeholder: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What maybe would be nice is a field where they list some relevant areas (e.g. mysql, postgres, macros, etc).
Also, "is this a breaking change? why or why not?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about the wording on this one. We maybe need to iterate on the wording a bit.
What kind of answers would you like to this question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And should this field be mandatory?
Being upfront: Sorry, hope that does not bother you too much |
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Does your PR solve an issue?
As discussed in #3471, I have added a field to the form.
I have also migrated to using issue-forms as they are a bit better too fill out and users are less likely to flat-out ignore the form.
You can preview it here: