Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse timezone parameter in mysql connection url #3418

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

parse timezone parameter in mysql connection url #3418

wants to merge 2 commits into from

Conversation

dojiong
Copy link

@dojiong dojiong commented Aug 8, 2024

Identify the timezone when parsing the url and set it by MySqlConnectOptions::timezone.

For example: mysql://user:pass@host/db?timezone=+08:00

CommanderStorm
CommanderStorm suggested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case below to ensure that no regressions happen on this parameter?

@dojiong
Copy link
Author

dojiong commented Aug 8, 2024

Could you add a test case below to ensure that no regressions happen on this parameter?

Done!

@dojiong dojiong mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommanderStorm CommanderStorm CommanderStorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dojiong @CommanderStorm