Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google provider): check if response body of GoogleProvider's getU… #688

Closed
wants to merge 1 commit into from

Conversation

alibori
Copy link
Contributor

@alibori alibori commented Feb 9, 2024

…serByToken method is a GuzzleHttp\Psr7\Stream instance

Fix TypeError error caused on GoogleProvider's getUserByToken method when trying to json_decode the response body.

…serByToken method is a GuzzleHttp\Psr7\Stream instance
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@alibori
Copy link
Contributor Author

alibori commented Feb 9, 2024

Ok! I'll try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants