Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Enhance error responses #1791

Merged

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Oct 3, 2024

This PR enhances error responses:

  • More meaningful error responses to adhere OpenID specs for prompt=none ([11.x] Support disabling prompt when redirecting for authorization #1569):
    • login_required (ref)
    • consent_required (ref)
  • Fix a bug on error responses of "implicit" grant. oauth2-server needs passing useFragment argument when generating redirect responses. Error parameters must be present on fragment instead of query parameters when redirecting to the client when using implicit grant.
  • Add more feature tests for "authorization code" grant.
  • Add feature tests for "authorization code" grant with PKCE.
  • Add feature tests for "implicit" grant.

@taylorotwell taylorotwell merged commit d80b6dd into laravel:13.x Oct 3, 2024
4 checks passed
@hafezdivandari hafezdivandari deleted the 13.x-enhance-error-responses branch October 3, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants