Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add k_mu source terms #172

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

WIP: Add k_mu source terms #172

wants to merge 4 commits into from

Conversation

AstroBarker
Copy link
Collaborator

This PR adds calculations for k_mu source terms (radiation/geodesics.hpp) for arbitrary metric/geometry as it was previously specialized to Minkowski. This was causing unphysical positions when running the torus problem. It now runs beyond the problem point and a longer run in in the queue. The leptoneq problem seems reasonable.

Also removes a print statement from plot_snap2d that I left from before.

TODO:

  • There are redundant calculations (in Minowski all the sources are 0, in FMKS only 2 are non zero) and we are doing more integration than necessary. Performant way to specialize? Template on geometry?
  • Write a simple test for particles around a Kerr black hole to say for sure that the Push is doing what we want.

@AstroBarker AstroBarker added the enhancement New feature or request label May 9, 2023
Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I can provide comparison data for the particle pushes soon. A lot of this can be done in a unit test, but ultimately I think it would be good to compare particles that have been pushed through the driver, to ensure that driver stages are interacting appropriately with the particle pushes. In that case a purpose-specific pgen that creates a few initial particles and then outputs particle positions with particle IO may be the right choice.

scripts/python/plot_snap2d.py Outdated Show resolved Hide resolved
src/radiation/geodesics.hpp Show resolved Hide resolved
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! As @brryan suggested, this is probably something we should be integrating more tightly with the geometry package, so that nothing here needs to be recalculated when there are symmetries. But that can be a future improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants