Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members initialization in AssociationParameters #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cguebert
Copy link
Contributor

There are currently 3 constructors for AssociationParameters, but not all initialize all the class members.
We can factor using class member initializers.
Also, calling default constructors for members is not necessary.

…here some members could have garbage values.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.693% when pulling fdf64eb on cguebert:master into a1be327 on lamyj:master.

@lamyj
Copy link
Owner

lamyj commented Oct 20, 2016

Sadly, I can't merge this yet: I still need to support Ubuntu 12.04 and its GCC 4.6, which does not have in-class initializers. I'll leave this PR open for now, since the official support (and hence Odil's support) will end at in March 2017.

@cguebert
Copy link
Contributor Author

At least we should fix the bug of _maximum_number_operations_invokedand _maximum_number_operations_performed not being initialized.

@lamyj
Copy link
Owner

lamyj commented Oct 26, 2016

Initialization is fixed in b3d1518 while waiting for Ubuntu 12.04 to be end-of-life.

@ferdymercury
Copy link
Contributor

@lamyj do you think this one could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants