[WIP] Validium PoC #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What ❔ * Fixing compilation error in Cargo * and clippy warning ## Why ❔ * To make CI pass
# What ❔ * Changed witness for snark wrapper - to pass the previous AUX and META fields * updated snark_wrapper_verification key to the latest version * updated the vk_hash to match the newly generated JSON, and made sure that it is being loaded at genesis. ## Why ❔ * to make boojnet work locally
# What ❔ * Adding zk status prover command to see the current state of FRI prover * mostly focused on local deployments (might require some changes before we run it on boojnet) ## Why ❔ * to better see what's going on in the prover pipeline ## Checklist ```shell zk status prover ``` 
…inputs (#157) # What ❔ * We were passing incorrect argument to the prover ## Why ❔ * to make prover work, the original problem was a simple bug/typo.
# What ❔ * Added CONTRACTS_PROVER_AT_GENESIS flag to control which prover should be used during genesis * Updated zk status command to compare the keys in the database and in the contracts ## Why ❔ * without this flag, we were pushing the old keys to the contracts, which resulted in failed proofs.
# What ❔ Prover and Witgen now use snark wrapper VKs to pick their jobs. ## Why ❔ `prover_protocol_versions` table had SNARK wrapper VKs, but prover and witgens picked jobs based on FRI scheduler VKs. Since if one changes the other also does, we can use the SNARK one instead, since it's also used in `eth_sender`. --------- Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
# What ❔ Checking out latest 'dev' branches in era-contracts and era-system-contracts ## Why ❔ To have the latest contracts changes after boojum-integration branches were merged to dev ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
# What ❔ Merge main branch into boojum-integration ## Why ❔ To not get far behind ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. --------- Signed-off-by: Danil <deniallugo@gmail.com> Co-authored-by: Yury Akudovich <ya@matterlabs.dev> Co-authored-by: Shahar Kaminsky <sk@matterlabs.dev> Co-authored-by: Aleksandr Stepanov <alexandrst88@gmail.com> Co-authored-by: Maksym <maksym.kryva@gmail.com> Co-authored-by: Danil <deniallugo@gmail.com> Co-authored-by: Alex Ostrovski <slowli@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: agolajko <57454127+agolajko@users.noreply.github.com> Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>
# What ❔ Use SNARK wrapper VK instead of FRI scheduler VK in proof_data_handler ## Why ❔ It will be saved to `prover_fri_protocol_versions`, and we need them consistent with `protocol_versions`. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
chore: Merge main into boojum-integration
Validium setup
|
@igamigo I'd love to see the draft. Do you mind rebasing this onto the main branch as the boojum-integration branch was merged into it? |
…un -v)" This was an issue with Docker version, it should work with 24.0.0. This reverts commit 9d8a57d.
|
Superseded by #11 |
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
Add comment on `MAX_SYSTEM_CONTRACT_ADDRESS` choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.