feat: Add gas reports for validium mode #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc-era into test-erc20-pubdata-0
* Add validium example readme * update validium.md and change test name * fmt --------- Co-authored-by: toni-calvin <antonio.calvin@lambdaclass.com>
* Update output readme * Add a note for transactions * Fix note
* remove logs from pubdata * update comment
* Refactor readme example * Fix some comments * Remove validium.md
ilitteri
requested changes
Jan 17, 2024
validium_report.sh
Outdated
There was a problem hiding this comment.
Lets move this script to validium_mode_example/scripts
Both reports and the graph should be stored in a directory |
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
Co-authored-by: agolajko <57454127+agolajko@users.noreply.github.com> Co-authored-by: agolajko <agostonlajko@gmail.com> Co-authored-by: Ramon Canales <emaildoramon@gmail.com> Co-authored-by: Yury Akudovich <ya@matterlabs.dev> Co-authored-by: Shahar Kaminsky <sk@matterlabs.dev>
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
* ci: testing added * test: temporarily commenting out failing tests * ci: cleaned up + added testing * fix: CI syntax * ci: added missing "needs" statement * ci: added missing node-setup * ci: added missing artifacts for cacheing * test: xdescribe and xit instead of commenting * chore: formatting
|
This is no longer necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds scripts to run the
validium_mode_examplein validium_mode and rollup_mode, and graph the results.Why ❔
To measure the gas cost reduction in validium mode compared to rollup, consider that does not store pubdata in L1.
Run
In
validium_mode_example/scripts/directoryFor Validium report run:
This will carate
validium_gas_report.csv.For Rollup report run:
This will carate
rollup_gas_report.csv.To create the graph run:
This will create a
graph.pngin that directory.