forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add native ERC20 token address endpoint #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
changed the title
Add native ERC20 token address endpoint
feat: Add native ERC20 token address endpoint
Jan 15, 2024
juanbono
requested review from
mationorato,
jrchatruc,
ilitteri and
IAvecilla
as code owners
January 15, 2024 19:17
fkrause98
reviewed
Jan 15, 2024
This endpoint fails for me with this curl:
I get this message:
Let me know if I'm testing this wrong, though EDIT:
|
fkrause98
approved these changes
Jan 15, 2024
jrchatruc
approved these changes
Jan 17, 2024
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
* feat: calculate-hashes * fix: build-yul command updated * chore: CI workflow renamed * feat(calculate-hashes): "--check-only" flag added * ci: calculate-hashes added to pipeline * modifying hash to test calculate-hashes in CI * Revert "modifying hash to test calculate-hashes in CI" This reverts commit 639650b3dfb4fcc7f64e75f316aa6262976c4c3f. * chore: bytecodeHash renamed * chore: importing and typo * feat: revert command renames * chore: major calculate-hashes refactor * ci: check hashes into separate job * ci: yarn cacheing * fix: absolutePath * fix: hash updated * fix: SHA256 hash updated * docs: readme updated * chore: changed hashes to array * chore: SystemContractsHashes updated * lint(calculate-hashes): format+lint * docs: command name typo * fix: calculate hashes updated * chore: automatic contracts details generation * chore: changed the order of json properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds a new RPC endpoint to get the Address of the native ERC20
it only adds a new method in the zks namespace.
Why ❔
This is needed by the explorer. More context here: #31
How to test
You first need to run
zk init --native-erc20
to deploy the required contracts and generate the native_erc20.json file.Then run the following command:
Checklist
zk fmt
andzk lint
.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1
.