-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EigenDA Disperser Store Module #309
EigenDA Disperser Store Module #309
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
disperser::{self, disperser_client::DisperserClient, BlobStatusRequest, DisperseBlobRequest}, | ||
}; | ||
|
||
pub struct EigenDAProxyClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be named EigenDAProxyClient since there is no proxy here.
|
||
let blob_status = blob_status_reply.status(); | ||
|
||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace for tracing::info
or tracing::debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good overall, but let's discuss the comments I left before approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d450836
into
da-eigen-implementation-m0
What ❔
This PR adds the Disperser store module (EigenDAClient), that communicates with the disperser grpc
It implements the
put_blob
andget_blob
functions, that will later be called by the/get
and/put
endpoints.In order to eventually run this, the config should be provided as followed on
etc/env/file_based/general.yaml
Why ❔
Checklist
zk_supervisor fmt
andzk_supervisor lint
.