Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EigenDA Disperser Store Module #309

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

gianbelinche
Copy link

@gianbelinche gianbelinche commented Oct 18, 2024

What ❔

This PR adds the Disperser store module (EigenDAClient), that communicates with the disperser grpc

It implements the put_blob and get_blob functions, that will later be called by the /get and /put endpoints.

In order to eventually run this, the config should be provided as followed on etc/env/file_based/general.yaml

da_client:
  eigen_da:
    disperser:
      api_node_url: http://127.0.0.1:4242 # TODO: This should be removed once eigenda proxy is no longer used
      disperser_rpc: <your_desired_disperser>
      eth_confirmation_depth: -1
      eigenda_eth_rpc: <your_desired_rpc>
      eigenda_svc_manager_addr: <your_svc_manager_addr>
      blob_size_limit: 2097152
      status_query_timeout: 1800
      status_query_interval: 5
      wait_for_finalization: false

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

Copy link

github-actions bot commented Oct 18, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "EigenDA Disperser Store Module". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

disperser::{self, disperser_client::DisperserClient, BlobStatusRequest, DisperseBlobRequest},
};

pub struct EigenDAProxyClient {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be named EigenDAProxyClient since there is no proxy here.

@gianbelinche gianbelinche marked this pull request as ready for review October 21, 2024 18:12

let blob_status = blob_status_reply.status();

println!(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace for tracing::info or tracing::debug

Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good overall, but let's discuss the comments I left before approval.

core/node/eigenda_proxy/src/blob_info.rs Outdated Show resolved Hide resolved
core/node/eigenda_proxy/src/blob_info.rs Outdated Show resolved Hide resolved
core/node/eigenda_proxy/src/blob_info.rs Outdated Show resolved Hide resolved
core/node/eigenda_proxy/src/eigenda_client.rs Outdated Show resolved Hide resolved
core/node/eigenda_proxy/src/eigenda_client.rs Outdated Show resolved Hide resolved
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianbelinche gianbelinche merged commit d450836 into da-eigen-implementation-m0 Oct 24, 2024
10 of 23 checks passed
@gianbelinche gianbelinche deleted the eigenda-disperser-client branch October 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants