Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get blob from L1 #282

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: Get blob from L1 #282

merged 2 commits into from
Sep 26, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR fixes a bug were the get all blobs script did not retrieve all blobs due to concurrency problems

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

juan518munoz
juan518munoz approved these changes Sep 26, 2024
View reviewed changes
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianbelinche gianbelinche merged commit 5021488 into da-eigen-implementation Sep 26, 2024
17 of 19 checks passed
@gianbelinche gianbelinche deleted the fix-get-all-blobs-l1 branch September 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@juan518munoz juan518munoz juan518munoz approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianbelinche @juanbono @juan518munoz