-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code for loadtests #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to work straightforwardly yet. Here is the list of things I have to do to use it.
- There's a function named
ArenaLoadTest.Utils.get_server_ip/1)
that might not be longer needed (because the env varTARGET_SERVER
now uses a public URL. This caused the load test to crash because the pattern matching doesn't catch this - In the load test server, I had to set the env var
OVERRRIDE_JWT
to true (I understand that this is going to be solved after we merged this PR)
I think we only need to solve 1)
As a heads up too, we might have to update the current |
Hmm I believe that was the old loadtest docs, we moved it when we split the repos. |
Done both! |
Thanks for the clarification! I thought that the information would be in that markdown. Maybe we can merge both markdowns 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work fixing load test! I only had to run the spawn players function to execute it!
Screen.Recording.2024-07-11.at.18.27.29.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! tested deploying both servers and the load tests runned like a charm
Motivation
Loadtests weren't working with current code, several changes made in arena broke the loadtests app.
Summary of changes
How to test it?
Run some loadtests and see if it works. Remember to set the new env var.
You can follow loadtest's README to do so.
Checklist