Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cairo trace #697

Draft
wants to merge 190 commits into
base: main
Choose a base branch
from
Draft

refactor: Cairo trace #697

wants to merge 190 commits into from

Conversation

entropidelic
Copy link
Contributor

No description provided.

@entropidelic
Add f_op1_imm_bit constraint
eea014e
@entropidelic
Add flag_res_op1_bit constraint
b8b8811
@entropidelic
Add flag_pc_update_regular_bit constraint
9132999
@entropidelic
Add flag_fp_update_regular_bit constraint
cd1c7c6
@entropidelic
Add cpu/opcodes/call/off0 constraint
1f0a852
@entropidelic
Add cpu/opcodes/call/off1 constraint
96b72c6
@entropidelic
Add cpu/opcodes/call/flags constraint
48285de
@entropidelic
Add cpu/opcodes/ret/off0 constraint
f3d608f
@entropidelic
Add cpu/opcodes/ret/off2 constraint
08138c4
@entropidelic
Add cpu/opcodes/ret/flags constraint
589423b
@entropidelic
Merge branch 'main' into add-constraints
718a062
@entropidelic
Fix wasm tes
20b6a75
@entropidelic
Merge remote-tracking branch 'origin/add-constraints' into add-constr…
e8be514 
…aints
@entropidelic
Fix wasm test
3680920
@entropidelic
Add layouts folder
029df35
@entropidelic
Merge branch 'main' into refactor-cairo-trace
817f5c3
@entropidelic
Add constants
a43a388
@entropidelic
Merge branch 'main' into refactor-cairo-trace
b8a3c92
@entropidelic
Add more trace cells position constants
dcf72ee
@entropidelic
Merge branch 'main' into refactor-cairo-trace
dad50aa
@entropidelic
Move plain layout AIR to its file
77f5b77
@entropidelic
Add set_offsets function
b16cf76
@entropidelic
Add test for set_offsets function
b8a19c3
@entropidelic entropidelic marked this pull request as ready for review November 24, 2023 17:10
@entropidelic entropidelic requested review from schouhy, ajgara and a team as code owners November 24, 2023 17:10
@entropidelic entropidelic marked this pull request as draft November 24, 2023 17:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024 •
edited
Loading

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (1a4a385) 94.45% compared to head (e91f61d) 93.65%.

Files Patch % Lines
provers/stark/src/trace.rs 64.64% 35 Missing ⚠️
provers/cairo/src/execution_trace.rs 95.59% 28 Missing ⚠️
provers/stark/src/traits.rs 50.00% 4 Missing ⚠️
provers/cairo/src/runner/run.rs 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   94.45%   93.65%   -0.81%     
==========================================
  Files         152      152              
  Lines       34539    32959    -1580     
==========================================
- Hits        32625    30867    -1758     
- Misses       1914     2092     +178

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

entropidelic and others added 18 commits January 26, 2024 17:25
@MauroToscano MauroToscano mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schouhy schouhy Awaiting requested review from schouhy

@ajgara ajgara Awaiting requested review from ajgara

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@entropidelic @codecov-commenter @MauroToscano