Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l1): implement TrieIterator + GetAccountRange snap request handling logic #960

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

feat(l1): implement TrieIterator + GetAccountRange snap request handling logic #960

wants to merge 27 commits into from

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Oct 23, 2024 •
edited
Loading

Motivation
Handling snap capability message GetAccountRange

Description

  • Add functionality to iterate the Trie (TrieIterator)
  • Add functionality to iterate over all accounts in the state (Store::iter_accounts)
  • Add logic to handle GetAccountRange snap request
  • Fix slim encoding of AccountState
  • Remove unneeded trait RLPEncodeSlim

Notes

  • We don't have the listen loop implemented so this PR only adds the standalone logic for handling the request and creating a response, we still need to plug it in to the main loop.
  • We are not able to run the hive test suite due to missing listen loop + old blocks being used by the test suite. I instead copied the state from a Geth execution (loading genesis + importing chain) and used that state to replicate hive tests as unit tests. These tests could be removed once we fix those two problems

Partially addresses #184

@fmoletta
Corrupted History Fix
02fe744 
This PR re-writes this branch's commits on top of the main branch:
- Implement TrieIterator
- Consume Trie when building TrieIterator
- Implement `Store::iter_accounts` using TrieIterator
@fmoletta
Fix slim encoding for AccountState
a2a2aac
@fmoletta
Fix slim encoding for AccountState
aef7441
@fmoletta
Commit progress
13d9bc3
@fmoletta
Commit progress
0ca3589
@fmoletta
Add snap as supported cap
66b6f90
@fmoletta
Push missing changes
41dcaff
@fmoletta
Deprecate RLPEncodeSlim trait and use AccountStateSlim instead
562bc49
@fmoletta
Fix logic
3893b05
@fmoletta
Remove debug print
dbe110f
@fmoletta
Limit response bytes
8b8eacb
@fmoletta
Add test
4ee1790
@fmoletta
Add more tests
d87b1ca
@fmoletta
Cleanup test code + Fix logic + add test
89621bf
@fmoletta
Add test
3a14cdd
@fmoletta
Add test
c354321
@fmoletta
Add test
7abd4f7
@fmoletta
Add test
7cee2b7
@fmoletta
Also fetch limit proof
579309f
@fmoletta
Trim test state 408 -> 100
9fccb07
@fmoletta
Simplify logic
38a7d5b
@fmoletta
Encode accounts while building range so we do not encode twice
704da4c
@fmoletta
Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…
b55294b 
…to trie_iter
@fmoletta
Clippy
6d5cc45
@fmoletta
Add allow tag
9514037
@fmoletta fmoletta changed the title feat(l1): implement TrieIterator + GetAccountRange snap request handling [WIP] feat(l1): implement TrieIterator + GetAccountRange snap request handling logic Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmoletta