-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SECP related hints #1829
base: main
Are you sure you want to change the base?
feat: SECP related hints #1829
Conversation
Problem: we need an implementation of the hints used by the Starknet OS in the secp syscalls. These hints rely on private primitives in `cairo-vm` and need to be implemented here. Solution: this PR adds an implementation of all the hints that require `cairo-vm` primitives in the `cairo-vm` repository.
Hi @odesenfans !! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
- Coverage 94.83% 94.31% -0.53%
==========================================
Files 101 102 +1
Lines 39579 40142 +563
==========================================
+ Hits 37536 37858 +322
- Misses 2043 2284 +241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@odesenfans some more points:
|
Context: port of the Starknet OS to Rust.
We need an implementation of the hints used by the Starknet OS in the SECP syscalls. These hints rely on private primitives in
cairo-vm
and must be implemented in this repository.Checklist