Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define custom raftify-cli --version command #161

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

CHOUMnote
Copy link
Contributor

Resolves: #155
This PR improves the version display behavior in raftify-cli:

-V option: Now shows only the raftify-cli version, maintaining its original purpose.
--version option: Displays both the raftify-cli version and the raftify version, providing a more comprehensive version report for the CLI and the underlying library.

@jopemachine jopemachine added good first issue Good for newcomers cli ossca-24 OSS Contribution Academy mentee's contributions. labels Oct 13, 2024
@jopemachine jopemachine changed the title feat: Separate outputs for -V and --version options feat: Define custom raftify-cli --version command Oct 13, 2024
@jopemachine
Copy link
Member

jopemachine commented Oct 13, 2024

Now the --version command now print the version of the built raftify-cli and raftify crate, along with a list of features enabled in the raftify crate.

❯ raftify-cli --version
raftify_cli 0.1.82
(Built with raftify 0.1.81, Enabled features: heed_storage, inmemory_storage, rocksdb_storage)

@CHOUMnote Thanks!

@jopemachine jopemachine merged commit 55bd392 into lablup:main Oct 13, 2024
5 checks passed
@CHOUMnote CHOUMnote deleted the feature/fix-cli branch October 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli good first issue Good for newcomers ossca-24 OSS Contribution Academy mentee's contributions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define custom raftify-cli --version command
2 participants