Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ssh_autodetect.py to support h3c device auto detect. #3397

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update ssh_autodetect.py to support h3c device auto detect. #3397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c59645
Update ssh_autodetect.py to support h3c device auto detect.
Mr-Jayden Mar 7, 2024
c0bef54
Update ssh_dispatcher.py
Mr-Jayden Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions netmiko/ssh_autodetect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@
"priority": 99,
"dispatch": "_autodetect_std",
},
"h3c": {
Copy link
Owner

@ktbyers ktbyers Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no h3c device_type in Netmiko.

This probably should return hp_compware or we should just put in another key to the ssh_dispatcher.py mapping h3c_compware to the HPComwareSSH class.

We should probably do the latter.

Do you want to implement that fix? If not, I will update this PR and implement it (just let me know).

@Mr-Jayden

"cmd": "display version",
"search_patterns": ["H3C Comware Software"],
"priority": 99,
"dispatch": "_autodetect_std",
},
"hp_comware": {
"cmd": "display version",
"search_patterns": ["HPE Comware", "HP Comware"],
Expand Down
Loading