Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siyuan upgrade node version in dockerfile #83

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tiansiyuan
Copy link
Contributor

The changed are verified via successful docker build using the new Dockerfile.

vikas-saxena02 and others added 2 commits June 14, 2024 21:53
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
Signed-off-by: Siyuan Tian <tiansiyuan@gmail.com>
@oss-prow-bot oss-prow-bot bot requested review from rimolive and yuzisun June 24, 2024 09:53
Copy link

oss-prow-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tiansiyuan
Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval by writing /assign @rimolive in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Contributor

That is even more confusing :-D but at least there is a PR with all fixes.

@juliusvonkohout
Copy link
Contributor

Can you rebase to master and fix the tests?

@juliusvonkohout
Copy link
Contributor

@markwinter can you help out here as well?

juliusvonkohout and others added 2 commits June 28, 2024 18:54
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Siyuan Tian <tiansiyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants