Skip to content

Commit

Permalink
chore: Rename webhook (HPA) (#415)
Browse files Browse the repository at this point in the history
Rename the `servingruntime.serving.kserve.io` validating webhook
in ModelMesh to resolve a naming conflict in KServe

Related kserve/kserve#3031
Related kserve/kserve#3061

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
(cherry picked from commit dbdb177)
  • Loading branch information
ckadner authored Aug 7, 2023
1 parent 0d7f19c commit 1e31708
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config/default/webhookcainjection_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: servingruntime.serving.kserve.io
name: modelmesh-servingruntime.serving.kserve.io
annotations:
cert-manager.io/inject-ca-from: $(CERTIFICATE_NAMESPACE_PLACEHOLDER)/$(CERTIFICATE_NAME_PLACEHOLDER)
2 changes: 1 addition & 1 deletion config/webhook/manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: servingruntime.serving.kserve.io
name: modelmesh-servingruntime.serving.kserve.io
webhooks:
- admissionReviewVersions:
- v1
Expand Down
4 changes: 2 additions & 2 deletions scripts/self-signed-ca.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ The following flags are optional.
--service Service name of webhook. Default: modelmesh-webhook-server-service
--namespace Namespace where webhook service and secret reside. Default: model-serving
--secret Secret name for CA certificate and server certificate/key pair. Default: modelmesh-webhook-server-cert
--webhookName Name for the mutating and validating webhook config. Default: servingruntime.serving.kserve.io
--webhookName Name for the mutating and validating webhook config. Default: modelmesh-servingruntime.serving.kserve.io
--webhookDeployment deployment name of the webhook controller. Default: modelmesh-controller
EOF
exit 1
Expand Down Expand Up @@ -70,7 +70,7 @@ done
[ -z ${secret} ] && secret=modelmesh-webhook-server-cert
[ -z ${namespace} ] && namespace=model-serving
[ -z ${webhookDeployment} ] && webhookDeployment=modelmesh-controller
[ -z ${webhookName} ] && webhookName=servingruntime.serving.kserve.io
[ -z ${webhookName} ] && webhookName=modelmesh-servingruntime.serving.kserve.io
[ -z ${service} ] && service=modelmesh-webhook-server-service
webhookDeploymentName=${webhookDeployment}
webhookConfigName=${webhookName}
Expand Down

0 comments on commit 1e31708

Please sign in to comment.