Minor UI fixes #1386
Minor UI fixes #1386
Conversation
| @@ -461,6 +461,10 @@ class InputBar extends StatelessWidget { | |||
| final data = content.data; | |||
| if (data == null) return; | |||
|
|
|||
| if (content.mimeType.startsWith("image/")) { | |||
| onSubmitImage!(data); | |||
There was a problem hiding this comment.
I use this feature mostly with the GBoard when sending a sticker or GIF. Having a dialog every time would be just overhead IMO
There was a problem hiding this comment.
Yeah... that will be very inconvenient....
But I think media is a bit expensive for the matrix. Currently both Android and web can upload images by pasting. So without visual confirmation, users might accidentally upload contents either they don't want or in its original quality (average screenshot takes about 7M, and in most case it's unnecessary to keep the original quality). Thus, putting more burden on home-level servers.
What if we only show the dialog for images larger than a certain size (e.g. 1M)?
| @@ -72,6 +73,10 @@ abstract class FluffyThemes { | |||
| useMaterial3: true, | |||
| brightness: brightness, | |||
| colorScheme: colorScheme, | |||
| cupertinoOverrideTheme: const CupertinoThemeData( | |||
| // This is required by adaptive_dialog | |||
There was a problem hiding this comment.
Can you explain here, why it is required?
There was a problem hiding this comment.
The issue:
The fix:
I thought this should be a common issue, so I've searched if there are any instructions.
and...
The change is guided by the readme of adaptive_dialog https://pub.dev/packages/adaptive_dialog#the-input-text-color-same-with-backgound-when-using-cupertinotextinputdialog
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Please make sure that your Pull Request meet the following acceptance criteria:
dart format lib/ test/anddart run import_sorter:main --no-commentsEvery new feature or change of the design/GUI is linked to an approved design proposal in an issueEvery new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainershipPull Request has been tested on:
Sorry for the missing test on iOS, I couldn't build for it.