Implement merge of config and credentials file #45
+75
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suxor42
force-pushed
the
merge_config_and_credentials
branch
3 times, most recently
from
515c850
to
d4df47f
Compare
Loading the profile data from the config and credentials files will new merge the data of the two files. The data in the second file is preferred. This means in the current load order that the credentials file will overwrite configuration in the config file. Test data and test was added for this case.
suxor42
force-pushed
the
merge_config_and_credentials
branch
from
d4df47f
to
f04d3ba
Compare
|
Hm. Looking at #43, re-reading the CLI documentation references there and having a look at the entries of my now de-symlinked config (specifically the SSO entries) I've come to the conclusion that Instead it should just look at |
|
After a bit of discussion the approach that would be most suitable seems to be indeed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the profile data from the config and credentials files
will new merge the data of the two files. The data in the second
file is preferred. This means in the current load order that the
credentials file will overwrite configuration in the config
file.
Test data and test was added for this case.