refactor: CI 통합 #42
Open
refactor: CI 통합 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaidBySolo
reviewed
Aug 15, 2022
Comment on lines
+76
to
+96
| deploy: | ||
| runs-on: ubuntu-latest | ||
| needs: [ style, type, build ] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.x' | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| pip install setuptools wheel twine | ||
| - name: Build and publish | ||
| env: | ||
| TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
| run: | | ||
| python setup.py sdist bdist_wheel | ||
| twine upload dist/* |
There was a problem hiding this comment.
이 프로세스는 빌드가 생성 될시에만 실행이 되나요?
There was a problem hiding this comment.
우선 build에 의존시켜뒀으니, 그럴거라고 생각합니다. 다만 테스트에서 오류가 나 이후의 동작은 확인하지 못했습니다.
There was a problem hiding this comment.
테스트 오류 해결 후 확인했습니다. build까지 동작 이후에 deploy가 동작합니다.
There was a problem hiding this comment.
배포는 릴리즈 이벤트가 발생될때만 작동하게 하면 될것같아요 :)
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 66.66% 65.33% -1.34%
==========================================
Files 10 9 -1
Lines 390 375 -15
==========================================
- Hits 260 245 -15
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style, type -> test -> deploy 순으로 진행되도록 CI를 한개 파일로 합쳤습니다.