Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix eslint setup after migration to new project layout #83

Merged
merged 2 commits into from
Oct 25, 2024
Merged

🐛 Fix eslint setup after migration to new project layout #83

merged 2 commits into from
Oct 25, 2024

Conversation

rszwajko
Copy link
Contributor

No description provided.

@rszwajko
Fix eslint setup after migration to new project layout
c477086 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko
Copy link
Contributor Author

@ibolton336
it might be my setup but I've encountered multiple eslint problems after the migration.
CLI included hidden vscode folders, the UI was failing to parse project (see below).
I've tweaked the config a bit and it works for me now. Please test on your env.

Screenshot from 2024-10-25 15-13-19

@rszwajko
Copy link
Contributor Author

@ibolton336
If you checkout a fresh project then the problems described above are not present. Not sure what was different in my case ;/ Changes in the eslint config seem neutral.

ibolton336
ibolton336 requested changes Oct 25, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
djzager
djzager previously approved these changes Oct 25, 2024
View reviewed changes
ibolton336
ibolton336 previously approved these changes Oct 25, 2024
View reviewed changes
@rszwajko rszwajko dismissed stale reviews from ibolton336 and djzager via d9db6e6 October 25, 2024 16:08
@rszwajko
Use projectService flag instead of older project setting
f46af95 
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
ibolton336
ibolton336 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after testing the setting on a fedora machine with eslint / eslint-prettier extensions.

@rszwajko rszwajko merged commit 50e6a6f into konveyor:main Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibolton336 ibolton336 ibolton336 approved these changes

@djzager djzager djzager left review comments

@sjd78 sjd78 Awaiting requested review from sjd78

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@hhpatel14 hhpatel14 Awaiting requested review from hhpatel14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rszwajko @djzager @ibolton336