-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Integrating release workflow - initial build, test, package, and upload artifacts to the ci runs. #34
✨ Integrating release workflow - initial build, test, package, and upload artifacts to the ci runs. #34
Conversation
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ adding initial release workflow
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
…tion Revert ":sparkles: adding initial release workflow"
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ Release automation
…ad artifacts to the ci runs. Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Ref issue: #11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you for making quick work of this. Only minor changes requested.
If you could please create an issue with all that you know to be required to publish to the VSCode marketplace and/or the Open VSX Registry, that would be fantastic.
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <6026527+savitharaghunathan@users.noreply.github.com>
✨ Release auto
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ testing alternative workflow
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ update action to release
28f40f2
to
9902042
Compare
Signed-off-by: Savitha Raghunathan <6026527+savitharaghunathan@users.noreply.github.com>
9902042
to
fdd6af8
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
fdd6af8
to
e2fa7ec
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
ed01e43
to
b0cbe77
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
f6c0fe4
to
547d1fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like moving this into ci-repo. A few comments.
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the last set of changes I'll need to ask for. Thank you for your patience, I really had not expected that we could make this so consumable for other stakeholders this quickly...really great work.
My requested changes reflect what I think to be the best option. You should also update the nightly workflow like:
jobs:
nightly:
uses: ./.github/workflows/ci-repo.yml
with:
shouldRelease: true
That will give us v0.0.1-dev+20241003
releases as early as tomorrow night that can with downloadable vscode extensions our stakeholders can install and use. Exceeds all of my expectations.
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few formatting comments that may be impactful.
formatting fixes dropping release name Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
18d462c
to
6170e60
Compare
@djzager ptal when you get some time. I am not able to test the release step on my fork. do you have any thoughts? Also, what do you mean by this -
comments for steps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This workflow builds the package, runs tests, and packages the extension. It also uploads it to the GH ci runs. It runs on merge and can be manually triggered on branches main and release-*. Supports linux, macos, windows.
ref issue: #11
todo:
Sample run - https://github.com/savitharaghunathan/editor-extensions/actions/runs/11111525940
I had to update the Readme as the
vsce package
fails if we use template generated readme file.