✨ Integrating release workflow - initial build, test, package, and upload artifacts to the ci runs. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ adding initial release workflow
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
…tion Revert ":sparkles: adding initial release workflow"
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ Release automation
…ad artifacts to the ci runs. Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
savitharaghunathan
requested review from
djzager,
rszwajko,
ibolton336 and
sjd78
|
Ref issue: #11 |
djzager
requested changes
Sep 30, 2024
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <6026527+savitharaghunathan@users.noreply.github.com>
✨ Release auto
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ testing alternative workflow
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
✨ update action to release
savitharaghunathan
force-pushed
the
release_auto
branch
from
28f40f2
to
9902042
Compare
Signed-off-by: Savitha Raghunathan <6026527+savitharaghunathan@users.noreply.github.com>
savitharaghunathan
force-pushed
the
release_auto
branch
from
9902042
to
fdd6af8
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
savitharaghunathan
force-pushed
the
release_auto
branch
from
fdd6af8
to
e2fa7ec
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
savitharaghunathan
force-pushed
the
release_auto
branch
from
ed01e43
to
b0cbe77
Compare
rszwajko
reviewed
Oct 2, 2024
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
savitharaghunathan
force-pushed
the
release_auto
branch
from
f6c0fe4
to
547d1fc
Compare
djzager
requested changes
Oct 2, 2024
djzager
reviewed
Oct 2, 2024
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
djzager
requested changes
Oct 3, 2024
There was a problem hiding this comment.
I think this is the last set of changes I'll need to ask for. Thank you for your patience, I really had not expected that we could make this so consumable for other stakeholders this quickly...really great work.
My requested changes reflect what I think to be the best option. You should also update the nightly workflow like:
jobs:
nightly:
uses: ./.github/workflows/ci-repo.yml
with:
shouldRelease: true
That will give us v0.0.1-dev+20241003 releases as early as tomorrow night that can with downloadable vscode extensions our stakeholders can install and use. Exceeds all of my expectations.
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
djzager
previously approved these changes
Oct 3, 2024
formatting fixes dropping release name Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
savitharaghunathan
force-pushed
the
release_auto
branch
from
18d462c
to
6170e60
Compare
|
@djzager ptal when you get some time. I am not able to test the release step on my fork. do you have any thoughts? Also, what do you mean by this -
comments for steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow builds the package, runs tests, and packages the extension. It also uploads it to the GH ci runs. It runs on merge and can be manually triggered on branches main and release-*. Supports linux, macos, windows.
ref issue: #11
todo:
Sample run - https://github.com/savitharaghunathan/editor-extensions/actions/runs/11111525940
I had to update the Readme as the
vsce packagefails if we use template generated readme file.