✨ Extension Configuration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
approved these changes
Sep 27, 2024
This PR makes the essential bits of our extension configurable in a VSCode native way. We now provide: 1. Configuration, which means the user can modify the configuration like any other extension in the application settings view. 1. Walkthroughs, that step the user through the different things that can be configured and how. 1. Some basic commands for configuring in a more hand-holding kind of way (filepicker for analyzer, picker for sources/targets, dialog to useDefaultRulesets). We leave the runAnalyzer piece unimplemented for now as that will come when it actually exists. Fixes konveyor#4 Fixes konveyor#5 Signed-off-by: David Zager <dzager@redhat.com>
djzager
force-pushed
the
user-config
branch
from
66847dd
to
eece3fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the essential bits of our extension configurable in a VSCode native way. We now provide:
We leave the runAnalyzer piece unimplemented for now as that will come when it actually exists.
Fixes #4
Fixes #5