Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sast-shell-check task #1437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add sast-shell-check task #1437

wants to merge 2 commits into from

Conversation

rhyw
Copy link

@rhyw rhyw commented Sep 18, 2024

No description provided.

@rhyw rhyw marked this pull request as draft September 19, 2024 09:29
@rhyw
Copy link
Author

rhyw commented Sep 19, 2024

Marking as draft for now since we'll need to comply with some sast convention first.

@rhyw rhyw force-pushed the sast-shellcheck branch 2 times, most recently from 0e75cb1 to 489ea23 Compare September 23, 2024 06:49
@rhyw rhyw changed the title add sast-shellcheck task add sast-shell-check task Sep 23, 2024
@rhyw rhyw force-pushed the sast-shellcheck branch 2 times, most recently from 016a826 to 3819a60 Compare September 23, 2024 11:26
task/sast-shell-check/0.1/README.md Outdated Show resolved Hide resolved
@rhyw
Copy link
Author

rhyw commented Sep 25, 2024

@kdudka I added 2 commits for review. I'll squash them into one single commit before it's getting merged.

@rhyw rhyw force-pushed the sast-shellcheck branch 2 times, most recently from 1c1285c to b7aa95f Compare September 26, 2024 13:36
@rhyw rhyw requested a review from kdudka September 26, 2024 13:53
task/sast-shell-check/0.1/sast-shell-check.yaml Outdated Show resolved Hide resolved
task/sast-shell-check/0.1/sast-shell-check.yaml Outdated Show resolved Hide resolved
@rhyw rhyw requested a review from kdudka September 27, 2024 03:14
@rhyw rhyw marked this pull request as ready for review September 30, 2024 11:14
task/sast-shell-check/0.1/sast-shell-check.yaml Outdated Show resolved Hide resolved
task/sast-shell-check/0.1/sast-shell-check.yaml Outdated Show resolved Hide resolved
@rhyw
Copy link
Author

rhyw commented Oct 8, 2024

Commits squashed for brevity.

Copy link

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Two remarks though:

@rhyw rhyw force-pushed the sast-shellcheck branch 2 times, most recently from 752fadd to a95fdc8 Compare October 9, 2024 05:44
@rhyw
Copy link
Author

rhyw commented Oct 9, 2024

It's weird the pipeline got stuck, I'm getting:
User rhyw is not allowed to trigger CI via pull_request on this repo.

Can anybody tell how can I re-trigger the CI?

@hanchuntao
Copy link
Contributor

It's weird the pipeline got stuck, I'm getting: User rhyw is not allowed to trigger CI via pull_request on this repo.

Can anybody tell how can I re-trigger the CI?

you can ask the reviewers to approve your request to trigger the CI

@tnevrlka
Copy link
Contributor

tnevrlka commented Oct 9, 2024

/ok-to-test

@rhyw rhyw force-pushed the sast-shellcheck branch 2 times, most recently from 9d8b4e9 to 9bfa582 Compare October 11, 2024 05:40
@rhyw
Copy link
Author

rhyw commented Oct 14, 2024

Hey can anyone from the konflux team please give a review on this? Thanks!

@rhyw
Copy link
Author

rhyw commented Oct 15, 2024

Added the sast-shell-check-oci-task in latest commit.

@rhyw
Copy link
Author

rhyw commented Oct 16, 2024

@brunoapimentel @tkdchen @owtaylor @14rcole @Josh-Everett @jsztuka would you mind give a reivew when got time please?

This has been pending for some time.

@rhyw
Copy link
Author

rhyw commented Oct 22, 2024

Rebased / added missing OWNERS file for the oci-ta task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants